Differential D26606

Don't pass window to KNotification
ClosedPublic
Actions

Authored by nicolasfella on Jan 12 2020, 5:09 PM.

Details

Reviewers
scarpino
Group Reviewers
Choqok
Commits
R186:435df2b76807: Don't pass window to KNotification
Summary

It doesn't do anything useful and will be removed

Test Plan

builds

Diff Detail

Repository
R186 Choqok
Branch
nowidget
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 21007
Build 21025: arc lint + arc unit
nicolasfella requested review of this revision.Jan 12 2020, 5:09 PM
nicolasfella created this revision.
scarpino added a subscriber: scarpino.Jan 14 2020, 12:43 PM

By passing the widget we set the notification parent to choqokMainWindow. Why is this a bad thing?

nicolasfella added a comment.Jan 14 2020, 1:05 PM

We are working on getting rid of QtWidgets in KNotifications so this constructor will disappear. There are some use-cases for having a parent widget left (like CloseWhenWidgetActivated), but none of them apply here.

scarpino accepted this revision.Jan 14 2020, 1:25 PM
This revision is now accepted and ready to land.Jan 14 2020, 1:25 PM
Closed by commit R186:435df2b76807: Don't pass window to KNotification (authored by nicolasfella). · Explain WhyJan 14 2020, 6:55 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mlibchoqok/notifymanager.cpp (2 lines)

Diff 73344

View Options

libchoqok/notifymanager.cpp

Loading...