Differential D26561

Always set MACOSX_DEPLOYMENT_TARGET
ClosedPublic
Actions

Authored by vonreth on Jan 10 2020, 1:41 PM.

Details

Reviewers
dschmidt
cullmann
fazevedo
arichardson
Commits
R138:a9cb4633b88a: Always set MACOSX_DEPLOYMENT_TARGET

Diff Detail

Repository
R138 Craft
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
vonreth requested review of this revision.Jan 10 2020, 1:41 PM
vonreth created this revision.
arichardson added inline comments.Jan 10 2020, 2:38 PM
CraftSettings.ini.template
27

If 5.14 minimum is 10.13, does it make sense to bump the minimum to 10.13 immediately instead of once we use 5.14?

vonreth added inline comments.Jan 10 2020, 2:57 PM
CraftSettings.ini.template
27

I kind of expecting a mixed result, aiming for a lower one here won't hurt as AFAIK Qt just takes what ever it likes

arichardson added a comment.Jan 10 2020, 3:10 PM

I may be misunderstanding this, but if Qt builds against a 10.13 target and we build frameworks against 10.12, is there any chance of breakage?
I can't think of any immediate problems since it should just mean Qt can use new APIs and no longer uses old deprecated ones.

Otherwise this change seems fine to me.

This revision was not accepted when it landed; it landed in state Needs Review.Jan 10 2020, 6:41 PM
Closed by commit R138:a9cb4633b88a: Always set MACOSX_DEPLOYMENT_TARGET (authored by vonreth). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 73222

View Options

CraftSettings.ini.template

Loading...
View Options

bin/BuildSystem/CMakeBuildSystem.py

Loading...
View Options

bin/CraftCompiler.py

Loading...
View Options

bin/CraftSetupHelper.py

Loading...
View Options

bin/shells.py

Loading...
View Options

bin/utils.py

Loading...