Use less Toplevel::isClient()
Needs ReviewPublic

Authored by zzag on Thu, Jan 9, 12:25 PM.

Details

Reviewers
None
Group Reviewers
KWin
Summary

Prefer qobject_cast<> over Toplevel::isClient() because it's more type
safer and makes code a bit more readable.

Hopefully, one day we will be able to get rid of isClient() altogether.

Test Plan

Compiles.

Diff Detail

Repository
R108 KWin
Branch
dont-use-toplevel-is-client
Lint
Lint ErrorsExcuse: cppcheck is dumb
SeverityLocationCodeMessage
Errorutils.h:123CppcheckunknownMacro
Unit
No Unit Test Coverage
Build Status
Buildable 20844
Build 20862: arc lint + arc unit
zzag created this revision.Thu, Jan 9, 12:25 PM
Restricted Application added a project: KWin. · View Herald TranscriptThu, Jan 9, 12:25 PM
Restricted Application added a subscriber: kwin. · View Herald Transcript
zzag requested review of this revision.Thu, Jan 9, 12:25 PM