Differential D26541

Use less Toplevel::isClient()
ClosedPublic
Actions

Authored by zzag on Jan 9 2020, 12:25 PM.

Details

Reviewers
None
Group Reviewers
KWin
Commits
R108:4d161bec4835: Use less Toplevel::isClient()
Summary

Prefer qobject_cast<> over Toplevel::isClient() because it's more type
safer and makes code a bit more readable.

Hopefully, one day we will be able to get rid of isClient() altogether.

Test Plan

Compiles.

Diff Detail

Repository
R108 KWin
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
zzag created this revision.Jan 9 2020, 12:25 PM
Restricted Application added a project: KWin. · View Herald TranscriptJan 9 2020, 12:25 PM
Restricted Application added a subscriber: kwin. · View Herald Transcript
zzag requested review of this revision.Jan 9 2020, 12:25 PM
This revision was not accepted when it landed; it landed in state Needs Review.Jan 23 2020, 10:29 AM
Closed by commit R108:4d161bec4835: Use less Toplevel::isClient() (authored by zzag). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mlayers.cpp (6 lines)
Mplugins/scenes/qpainter/scene_qpainter.cpp (15 lines)

Diff 74205

View Options

layers.cpp

Loading...
View Options

plugins/scenes/qpainter/scene_qpainter.cpp

Loading...