Differential D26459

Provide a KWindowShadow implementation for internal clients
ClosedPublic
Actions

Authored by zzag on Jan 6 2020, 10:34 AM.

Tags

Subscribers

davidedmundson, kwin

Details

Reviewers

Group Reviewers

Maniphest Tasks

T12496: Shadows API in KWindowSystem

Commits

R108:fb598c65b8eb: Provide a KWindowShadow implementation for internal clients

Diff Detail

Repository

Branch

port-to-shadows-api

Lint

Lint Errors

Excuse: jdsfjdsla;fjas

Severity	Location	Code	Message
Error	input.h:310	Cppcheck	unknownMacro
Error	input.h:310	Cppcheck	unknownMacro

Unit

No Unit Test Coverage

Build Status

Buildable 21250
Build 21268: arc lint + arc unit

zzag created this revision.Jan 6 2020, 10:34 AM

Restricted Application added a project: KWin. · View Herald TranscriptJan 6 2020, 10:34 AM

Restricted Application added a subscriber: kwin. · View Herald Transcript

zzag requested review of this revision.Jan 6 2020, 10:34 AM

Harbormaster completed remote builds in B20692: Diff 72865.Jan 6 2020, 10:34 AM

Due to frameworks cycles, this will have to wait till 5.19

In D26459#588565, @davidedmundson wrote:

Due to frameworks cycles, this will have to wait till 5.19

Yes, I'm afraid so. :(

This patch depends on D26457.

Adjust to recent KWindowShadow changes

Harbormaster completed remote builds in B21250: Diff 73730.Jan 16 2020, 6:00 PM

davidedmundson accepted this revision.Jan 21 2020, 11:36 PM

This revision is now accepted and ready to land.Jan 21 2020, 11:36 PM

Closed by commit R108:fb598c65b8eb: Provide a KWindowShadow implementation for internal clients (authored by zzag). · Explain WhyJan 22 2020, 12:21 AM

This revision was automatically updated to reflect the committed changes.

Showing Only Differences

This revision modifies 3 more files that are hidden because they were not modified between selected diffs and they have no inline comments.

Revision Contents
Changeset List

			Path	Packages
M			internal_client.cpp (5 lines)
P			plugins/windowsystem/windowshadow.h (33 lines) Copied from plugins/windowsystem/plugin.cpp
A	M		plugins/windowsystem/windowshadow.cpp (95 lines)
M			shadow.h (3 lines)
M			shadow.cpp (76 lines)

Diff 73730

internal_client.cpp

Loading...

plugins/windowsystem/windowshadow.h

Loading...

plugins/windowsystem/windowshadow.cpp

Loading...

shadow.h

Loading...

shadow.cpp

Loading...