Don't run qmllint if ECM_ENABLE_SANITIZERS is defined
ClosedPublic

Authored by jjazeix on Jan 3 2020, 5:03 PM.

Details

Summary

Should fix the CI

Diff Detail

Lint
Lint Skipped
Unit
Unit Tests Skipped
jjazeix created this revision.Jan 3 2020, 5:03 PM
Restricted Application added a project: Plasma. · View Herald TranscriptJan 3 2020, 5:03 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
jjazeix requested review of this revision.Jan 3 2020, 5:03 PM
jjazeix updated this revision to Diff 72700.Jan 3 2020, 5:08 PM
mvourlakos accepted this revision.Jan 3 2020, 5:33 PM
This revision is now accepted and ready to land.Jan 3 2020, 5:33 PM

Unfortunate, it definitely looked like QMLLint was the cause of the issues.

Given that Latte Dock is the only application impacted by this, does it do anything else special with regards to linking the application (such as not making use of ECM).

jjazeix added a comment.EditedJan 3 2020, 6:46 PM

Unfortunate, it definitely looked like QMLLint was the cause of the issues.

Given that Latte Dock is the only application impacted by this, does it do anything else special with regards to linking the application (such as not making use of ECM).

I revert this change and added back include(KDECompilerSettings NO_POLICY_SCOPE) in the CMakeLists.txt.
The build is now ok (https://build.kde.org/job/Extragear/job/latte-dock/job/kf5-qt5%20FreeBSDQt5.13/). I guess it was missing the flags during the link provided by this module (-fsanitize=address -fno-omit-frame-pointer -fno-optimize-sibling-calls)
@mvourlakos is the change ok for you?
If yes, I can add it in the stable branch too.

Thanks for sorting that Johnny, it's appreciated.

Unfortunate, it definitely looked like QMLLint was the cause of the issues.

Given that Latte Dock is the only application impacted by this, does it do anything else special with regards to linking the application (such as not making use of ECM).

I revert this change and added back include(KDECompilerSettings NO_POLICY_SCOPE) in the CMakeLists.txt.
The build is now ok (https://build.kde.org/job/Extragear/job/latte-dock/job/kf5-qt5%20FreeBSDQt5.13/). I guess it was missing the flags during the link provided by this module (-fsanitize=address -fno-omit-frame-pointer -fno-optimize-sibling-calls)
@mvourlakos is the change ok for you?
If yes, I can add it in the stable branch too.

No prob... Did I understood correctly that this was fixable on your side without any need to touch Latte code? (dont worry about commiting and reverting)

It was the Latte Dock code that needed adjusting to make use of ECM's KDECompilerSettings module.

jjazeix closed this revision.Jan 3 2020, 7:32 PM

No prob... Did I understood correctly that this was fixable on your side without any need to touch Latte code? (dont worry about commiting and reverting)

I updated the CMakeLists.txt: https://cgit.kde.org/latte-dock.git/diff/CMakeLists.txt?id=d2170f13c04e13e392ae780ee28b60ddebb20c9a

It was the Latte Dock code that needed adjusting to make use of ECM's KDECompilerSettings module.

Oh, I had commented a line in cmake...
I can not remember why...
no prob, it still builds in my system.

@jjazeix please apply it to stable branch also