Should fix the CI
Details
Diff Detail
- Lint
Lint Skipped - Unit
Unit Tests Skipped
Commited in https://commits.kde.org/latte-dock/e705eed41556649661f959b714a016938c19817c
Build still not ok in https://build.kde.org/job/Extragear/job/latte-dock/job/kf5-qt5%20FreeBSDQt5.13/118/console
The issue is due to the link error, probably not qmllint
Unfortunate, it definitely looked like QMLLint was the cause of the issues.
Given that Latte Dock is the only application impacted by this, does it do anything else special with regards to linking the application (such as not making use of ECM).
I revert this change and added back include(KDECompilerSettings NO_POLICY_SCOPE) in the CMakeLists.txt.
The build is now ok (https://build.kde.org/job/Extragear/job/latte-dock/job/kf5-qt5%20FreeBSDQt5.13/). I guess it was missing the flags during the link provided by this module (-fsanitize=address -fno-omit-frame-pointer -fno-optimize-sibling-calls)
@mvourlakos is the change ok for you?
If yes, I can add it in the stable branch too.
No prob... Did I understood correctly that this was fixable on your side without any need to touch Latte code? (dont worry about commiting and reverting)
It was the Latte Dock code that needed adjusting to make use of ECM's KDECompilerSettings module.
No prob... Did I understood correctly that this was fixable on your side without any need to touch Latte code? (dont worry about commiting and reverting)
I updated the CMakeLists.txt: https://cgit.kde.org/latte-dock.git/diff/CMakeLists.txt?id=d2170f13c04e13e392ae780ee28b60ddebb20c9a
Oh, I had commented a line in cmake...
I can not remember why...
no prob, it still builds in my system.
@jjazeix please apply it to stable branch also
@jjazeix please apply it to stable branch also
Done: https://commits.kde.org/latte-dock/e740bd38032441d5c03ba5321a76dad0ba5af9b9
Build ok: https://build.kde.org/job/Extragear/job/latte-dock/job/stable-kf5-qt5%20FreeBSDQt5.13/102/