Differential D26365

Embed protocol data also for Windows version of trash ioslave.
ClosedPublic
Actions

Authored by tfry on Jan 2 2020, 1:58 PM.

Details

Reviewers
cullmann
vonreth
Commits
R241:cb33e9478e58: Embed protocol data also for Windows version of trash ioslave.
Summary

trash:/-protocol is currently broken on Windows: https://bugs.kde.org/show_bug.cgi?id=414430

The cause seems to be that the trash-protocol meta data is not installed on Windows: The protocol is
built from entirely separate sources on Windows, and the Windows-version was forgotten in this commit:
https://cgit.kde.org/kio.git/commit/src/ioslaves/trash/CMakeLists.txt?id=a3fee508c6c42b1b86155719e38a84b1128360eb

Test Plan

This patch fixes the problem for me on Windows 8.1, MinGW64

Diff Detail

Repository
R241 KIO
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
tfry created this revision.Jan 2 2020, 1:58 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptJan 2 2020, 1:58 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
tfry requested review of this revision.Jan 2 2020, 1:58 PM
cullmann accepted this revision.Jan 2 2020, 3:25 PM

Makes sense for me, thanks for taking care of this.

This revision is now accepted and ready to land.Jan 2 2020, 3:25 PM
Closed by commit R241:cb33e9478e58: Embed protocol data also for Windows version of trash ioslave. (authored by tfry). · Explain WhyJan 2 2020, 7:28 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 72644

View Options

src/ioslaves/trash/kio_trash_win.cpp

Loading...