Differential D2636

Remove non visible internal windows from the x stacking order
ClosedPublic
Actions

Authored by graesslin on Aug 31 2016, 2:13 PM.

Details

Reviewers
mart
Group Reviewers
Plasma on Wayland
KWin
Commits
R108:8d4204ac0d13: Remove non visible internal windows from the x stacking order
Summary

KWin always has a few internal windows around which are not visible.
A QWindow created somewhere, but not shown. Such windows should not
be part of the stacking order.

If they are it breaks code which looks at the top most window in the
stacking order like e.g. SlidebackEffect.

This change ensures that the stacking order gets updated whenever a
ShellClient gets hidden and that internal windows with isShown being
false are excluded from the stacking order.

BUG: 364483

Diff Detail

Repository
R108 KWin
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
graesslin updated this revision to Diff 6393.Aug 31 2016, 2:13 PM
graesslin retitled this revision from to Remove non visible internal windows from the x stacking order.
graesslin updated this object.
graesslin edited the test plan for this revision. (Show Details)
graesslin added reviewers: KWin, Plasma on Wayland.
Restricted Application added projects: Plasma on Wayland, KWin. · View Herald TranscriptAug 31 2016, 2:13 PM
Restricted Application added subscribers: kwin, plasma-devel. · View Herald Transcript
mart accepted this revision.Sep 2 2016, 8:29 AM
mart added a reviewer: mart.
This revision is now accepted and ready to land.Sep 2 2016, 8:29 AM
Closed by commit R108:8d4204ac0d13: Remove non visible internal windows from the x stacking order (authored by graesslin). · Explain WhySep 9 2016, 5:42 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mautotests/integration/internal_window.cpp (12 lines)
Mlayers.cpp (4 lines)
Mworkspace.cpp (7 lines)

Diff 6568

View Options

autotests/integration/internal_window.cpp

Loading...
View Options

layers.cpp

Loading...
View Options

workspace.cpp

Loading...