Differential D2623

Don't set Service as parent to KJob
ClosedPublic
Actions

Authored by davidedmundson on Aug 29 2016, 3:17 PM.

Details

Reviewers
mart
Group Reviewers
Plasma
Commits
R120:19e1d474d99a: Don't set Service as parent to KJob
R871:19e1d474d99a: Don't set Service as parent to KJob
Summary

Otherwise Solid ejects a device
Plasma removes the device from the notifier
The notifier kills SolidDeviceService (directly)
That kills the SolidDeviceJob
This leaves SolidDeviceJob still in the middle of SolidDeviceJob::start() with "this"
now referring to a dangling pointer.

BUG: 361450

Diff Detail

Repository
R120 Plasma Workspace
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
davidedmundson updated this revision to Diff 6360.Aug 29 2016, 3:17 PM
davidedmundson retitled this revision from to Don't set Service as parent to KJob.
davidedmundson updated this object.
davidedmundson edited the test plan for this revision. (Show Details)
davidedmundson added a reviewer: Plasma.
Restricted Application added a project: Plasma. · View Herald TranscriptAug 29 2016, 3:17 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
mart accepted this revision.Aug 29 2016, 3:18 PM
mart added a reviewer: mart.
This revision is now accepted and ready to land.Aug 29 2016, 3:18 PM
Closed by commit R120:19e1d474d99a: Don't set Service as parent to KJob (authored by davidedmundson). · Explain WhyAug 29 2016, 3:26 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 6361

View Options

dataengines/soliddevice/soliddeviceservice.cpp

Loading...