Differential D2616

setDesktopFileName for marble-maps
ClosedPublic
Actions

Authored by bshah on Aug 28 2016, 2:29 PM.

Details

Reviewers
kossebau
Group Reviewers
Marble
Commits
R34:0779aa8abcd3: setDesktopFileName for marble-maps
Summary

this way it can show icons set on wayland

Diff Detail

Repository
R34 Marble
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
bshah updated this revision to Diff 6336.Aug 28 2016, 2:29 PM
bshah retitled this revision from to setDesktopFileName for marble-maps.
bshah updated this object.
bshah edited the test plan for this revision. (Show Details)
bshah added a reviewer: Marble.
kossebau requested changes to this revision.Aug 28 2016, 2:48 PM
kossebau added a reviewer: kossebau.
kossebau added a subscriber: kossebau.

Looks good, please apply the two changes though first.

src/apps/marble-maps/main.cpp
34

For consistency with other Marble code please use
#if QT_VERSION >= 0x050700

35

Please use QStringLiteral, other code is currently prepared for that, so soon will be consistent.

This revision now requires changes to proceed.Aug 28 2016, 2:48 PM
bshah updated this revision to Diff 6337.Aug 28 2016, 2:53 PM
bshah edited edge metadata.
bshah marked 2 inline comments as done.

change as requested

kossebau accepted this revision.Aug 28 2016, 3:09 PM
kossebau edited edge metadata.
This revision is now accepted and ready to land.Aug 28 2016, 3:09 PM
Closed by commit R34:0779aa8abcd3: setDesktopFileName for marble-maps (authored by bshah). · Explain WhyAug 28 2016, 3:11 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/apps/marble-maps/main.cpp (3 lines)

Diff 6340

View Options

src/apps/marble-maps/main.cpp

Loading...