Don't load the system tray containment via two different code paths
AbandonedPublic

Authored by davidedmundson on Aug 28 2016, 1:03 PM.

Details

Reviewers
mart
Group Reviewers
Plasma
Summary

We have everything we need in Applet::init there is no need to sometimes
load it then, sometimes in UiReadyConstraint especially as it then
requires further hacks on the QML side to manage that.

Should be faster, cleaner and also fixes a warning about binding a layout to a null Item.

Test Plan

Loaded plasmashell with my config
Loaded plasmashell after deleting my config

Diff Detail

Repository
R120 Plasma Workspace
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
davidedmundson retitled this revision from to Don't load the system tray containment via two different code paths.
davidedmundson updated this object.
davidedmundson edited the test plan for this revision. (Show Details)
davidedmundson added a reviewer: Plasma.
Restricted Application added a project: Plasma. · View Herald TranscriptAug 28 2016, 1:03 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
mart accepted this revision.Aug 29 2016, 9:29 AM
mart added a reviewer: mart.
mart added a subscriber: mart.

are we really sure that when applet::init runs we always have already an instance of the systray containment?
i am under the impression (needs to be tested, would love being wrong) that this way a new containment from scratch will be created on each session with them pilinug up in appletsrc?

This revision is now accepted and ready to land.Aug 29 2016, 9:29 AM
mart commandeered this revision.Aug 29 2016, 9:30 AM
mart edited reviewers, added: davidedmundson; removed: mart.

err, didn't mean to accept, needs such testing

This revision now requires review to proceed.Aug 29 2016, 9:30 AM
davidedmundson commandeered this revision.Aug 29 2016, 11:18 AM
davidedmundson abandoned this revision.
davidedmundson edited reviewers, added: mart; removed: davidedmundson.