Differential D2609

Drop custom systemsettings import, move to QtQml.styleHints
AbandonedPublic
Actions

Authored by davidedmundson on Aug 27 2016, 6:56 PM.

Details

Reviewers

hein

Group Reviewers

Plasma

Summary

Cleaner code

Test Plan

grep all QML for any other users of SystemSettings
Test applet handles still appear
Test single/double click in folderview
Test drag isn't super instant on folderview items

Diff Detail

Repository

R119 Plasma Desktop

Branch

master

Lint

No Linters Available

Unit

No Unit Test Coverage

davidedmundson updated this revision to Diff 6327.Aug 27 2016, 6:56 PM

davidedmundson retitled this revision from to Drop custom systemsettings import, move to QtQml.styleHints.

davidedmundson updated this object.

davidedmundson edited the test plan for this revision. (Show Details)

davidedmundson added a reviewer: Plasma.

Restricted Application added a project: Plasma. · View Herald TranscriptAug 27 2016, 6:56 PM

Restricted Application added a subscriber: plasma-devel. · View Herald Transcript

Nice cleanup!

This revision is now accepted and ready to land.Aug 28 2016, 8:44 AM

davidedmundson abandoned this revision.Aug 28 2016, 5:23 PM

Revision Contents
Changeset List

		Path
M		containments/desktop/package/contents/ui/AppletAppearance.qml (6 lines)
M		containments/desktop/package/contents/ui/ConfigIcons.qml (7 lines)
M		containments/desktop/package/contents/ui/FolderItemDelegate.qml (2 lines)
M		containments/desktop/package/contents/ui/FolderView.qml (7 lines)
M		containments/desktop/package/contents/ui/main.qml (6 lines)
M		containments/desktop/plugins/desktop/CMakeLists.txt (2 lines)
M		containments/desktop/plugins/desktop/desktopplugin.cpp (2 lines)
D	M	containments/desktop/plugins/desktop/systemsettings.h (41 lines)
D	M	containments/desktop/plugins/desktop/systemsettings.cpp (50 lines)