Differential D26062

Port to QRandomGenerator
ClosedPublic
Actions

Authored by mlaurent on Dec 17 2019, 5:29 AM.

Details

Reviewers
dfaure
Commits
R293:b5c7c6b7012a: Port to QRandomGenerator
Summary

qrand is deprecated in qt5.15

Diff Detail

Repository
R293 Baloo
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
mlaurent created this revision.Dec 17 2019, 5:29 AM
Restricted Application added projects: Frameworks, Baloo. · View Herald TranscriptDec 17 2019, 5:29 AM
Restricted Application added subscribers: Baloo, kde-frameworks-devel. · View Herald Transcript
mlaurent requested review of this revision.Dec 17 2019, 5:29 AM
dfaure requested changes to this revision.Dec 18 2019, 10:56 AM
dfaure added inline comments.
autotests/unit/lib/filemonitortest.cpp
198

I'd suggest extracting the call to global() outside the loop. It's very likely not inline.

This revision now requires changes to proceed.Dec 18 2019, 10:56 AM
mlaurent updated this revision to Diff 71829.Dec 19 2019, 5:55 AM

Move QRandomGenerator::global() outside loop

dfaure accepted this revision.Dec 20 2019, 11:37 PM
This revision is now accepted and ready to land.Dec 20 2019, 11:37 PM
Closed by commit R293:b5c7c6b7012a: Port to QRandomGenerator (authored by mlaurent). · Explain WhyDec 21 2019, 8:22 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 71927

View Options

autotests/unit/lib/filemonitortest.cpp

Loading...