Differential D25989

Don't build and install app templates on android
ClosedPublic
Actions

Authored by jbbgameich on Dec 14 2019, 1:41 PM.

Details

Reviewers
nicolasfella
Group Reviewers
Kirigami
Android
Commits
R169:3bc41934f9d6: Don't build and install app templates on android
Summary

They increase apk sizes and are really not required in an apk.

Diff Detail

Repository
R169 Kirigami
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
jbbgameich created this revision.Dec 14 2019, 1:41 PM
Restricted Application added a project: Kirigami. · View Herald TranscriptDec 14 2019, 1:41 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
jbbgameich requested review of this revision.Dec 14 2019, 1:41 PM
nicolasfella added a subscriber: nicolasfella.Dec 14 2019, 1:48 PM
nicolasfella added inline comments.
CMakeLists.txt
123–125

if(ANDROID) is enough

123–125

if (NOT ANDROID) obviously

jbbgameich updated this revision to Diff 71517.Dec 14 2019, 1:51 PM

Follow suggestion

nicolasfella accepted this revision.Dec 14 2019, 1:52 PM
This revision is now accepted and ready to land.Dec 14 2019, 1:52 PM
Closed by commit R169:3bc41934f9d6: Don't build and install app templates on android (authored by jbbgameich). · Explain WhyDec 14 2019, 2:02 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
MCMakeLists.txt (4 lines)

Diff 71518

View Options

CMakeLists.txt

Loading...