Resize file dialog window before size restore

Authored by davidedmundson on Dec 14 2019, 12:53 PM.



KDEPlatformDialogHelper explicitly resizes the window contents to the
window as part of a bug fix. This means we lose the common path where
the window resizes to the content's size hints that happens later.

If we resize the window to the size hint in advance we keep our size

(alternatively it seems to be me we can remove that old hack...but it
needs testing by people with Qt5.12)

Test Plan

KWrite -> open

Size is 900x600, the size hint
not 640x480 the QPA default

Diff Detail

R135 Integration for Qt applications in Plasma
Automatic diff as part of commit; lint not applicable.
Automatic diff as part of commit; unit tests not applicable.
Restricted Application added a project: Plasma. · View Herald TranscriptDec 14 2019, 12:53 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
davidedmundson requested review of this revision.Dec 14 2019, 12:53 PM
ngraham accepted this revision.Dec 14 2019, 12:57 PM
ngraham added a subscriber: ngraham.

Fantastic!!! This fixes the file dialogs being way too tiny by default. Marvelous.

This revision is now accepted and ready to land.Dec 14 2019, 12:57 PM

Could this go on the stable branch?

This revision was automatically updated to reflect the committed changes.