Port pykig to python 3
ClosedPublic
Actions

Authored by arojas on Dec 14 2019, 10:31 AM.

Details

Reviewers

yurchor

Group Reviewers

KDE Edu

Commits

R331:d72f33a14c22: Port pykig to python 3

Summary

Not backwards compatible with python2, but I don't think that's worth it since it will be EOL in a matter of days.

Test Plan

Tested some scripts from http://ftp.dmf.unicatt.it/~paolini/kig/pykig/examples/, some work, the ones that don't also didn't work before the patch.

Repository

R331 Kig

Lint

Lint Skipped

Unit

Unit Tests Skipped

Restricted Application added a subscriber: kde-edu. · View Herald Transcript

arojas requested review of this revision.Dec 14 2019, 10:31 AM

Thanks. Can you change the shebang to #!/usr/bin/env python3 as well?

pykig/pykig.py
808 ↗	(On Diff #71497)	Why is this commented out?

Update shebang, fix typo

arojas marked an inline comment as done.Dec 14 2019, 12:12 PM

arojas added inline comments.

pykig/pykig.py
808 ↗	(On Diff #71497)	Unintended, I probably pressed CTRL+D instead of CTRL+C

This revision is now accepted and ready to land.Dec 14 2019, 12:44 PM

This revision was automatically updated to reflect the committed changes.

arojas marked an inline comment as done.

			Path	Packages
M			pykig/pykig.py (42 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	71497			Dec 14 2019, 10:28 AM	★	★
Diff 2	71505			Dec 14 2019, 12:11 PM	★	★
Diff 3	71544	da7cf04	R331:d72f33a14c22480b28c0f35d53293826f6ec787b	Dec 14 2019, 6:49 PM	★	★