Differential D25971

Use text color for "No preview image" text
ClosedPublic
Actions

Authored by filipf on Dec 13 2019, 10:18 PM.

Details

Reviewers
ngraham
Group Reviewers
Plasma
VDG
Commits
R123:7e13183d044b: Use text color for "No preview image" text
Summary

The text that shows up as the theme preview when no image preview is available was always just black.

That's not great for dark themes so this patch makes it use text color.

Test Plan

Before:

After:

Diff Detail

Repository
R123 SDDM Configuration Panel (KCM)
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
filipf created this revision.Dec 13 2019, 10:18 PM
Restricted Application added a project: Plasma. · View Herald TranscriptDec 13 2019, 10:18 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
filipf requested review of this revision.Dec 13 2019, 10:18 PM
filipf edited the test plan for this revision. (Show Details)Dec 13 2019, 10:19 PM
filipf added reviewers: Plasma, VDG.
filipf retitled this revision from Use text color for "No preview image text" to Use text color for "No preview image" text.
ngraham accepted this revision.Dec 13 2019, 10:21 PM
ngraham added a subscriber: ngraham.

clearly correct, stable branch please

This revision is now accepted and ready to land.Dec 13 2019, 10:21 PM
Closed by commit R123:7e13183d044b: Use text color for "No preview image" text (authored by filipf). · Explain WhyDec 14 2019, 9:48 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/themesdelegate.cpp (2 lines)

Diff 71560

View Options

src/themesdelegate.cpp

Loading...