Differential D2596

[Colors KCM] Disable "Edit Scheme" button if cannot be edited
ClosedPublic
Actions

Authored by broulik on Aug 26 2016, 8:15 PM.

Details

Reviewers
graesslin
Group Reviewers
Plasma
Commits
R119:d150b5503a0d: [Colors KCM] Disable "Edit Scheme" button if cannot be edited
Summary

The default scheme cannot be edited, yields a "Scheme not found" error when trying to, and when no scheme is selected, we cannot edit it either.

Test Plan

When edit scheme dialog closes, no scheme is selected in the list, previously the KCM would crash when clicking Edit scheme again. I also no longer get a "Scheme not found" warning when trying to edit the default scheme because I no longer can.

It's quite annoying that the buttons have no edit or remove icon, though.

Diff Detail

Repository
R119 Plasma Desktop
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
broulik updated this revision to Diff 6311.Aug 26 2016, 8:15 PM
broulik retitled this revision from to [Colors KCM] Disable "Edit Scheme" button if cannot be edited.
broulik updated this object.
broulik edited the test plan for this revision. (Show Details)
broulik added a reviewer: Plasma.
broulik set the repository for this revision to R119 Plasma Desktop.
Restricted Application added a project: Plasma. · View Herald TranscriptAug 26 2016, 8:15 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
graesslin accepted this revision.Aug 29 2016, 6:01 AM
graesslin added a reviewer: graesslin.
This revision is now accepted and ready to land.Aug 29 2016, 6:01 AM
Closed by commit R119:d150b5503a0d: [Colors KCM] Disable "Edit Scheme" button if cannot be edited (authored by broulik). · Explain WhyAug 29 2016, 12:57 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mkcms/colors/colorscm.cpp (8 lines)

Diff 6356

View Options

kcms/colors/colorscm.cpp

Loading...