Differential D25963

Avoid const references for return types
AbandonedPublic
Actions

Authored by yurchor on Dec 13 2019, 7:19 PM.

Details

Reviewers
None
Group Reviewers
KDE Games
Summary

Implement EBN recommendation

http://ebn.kde.org/krazy/reports/kde-4.x/kdegames/libkdegames/index.html

Test Plan

Compiles, installs, no visible changes in the KFourInLine chat dialog.

Diff Detail

Repository
R420 KDE Games Library
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 19807
Build 19825: arc lint + arc unit
yurchor created this revision.Dec 13 2019, 7:19 PM
Restricted Application added a subscriber: kde-games-devel. · View Herald TranscriptDec 13 2019, 7:19 PM
yurchor requested review of this revision.Dec 13 2019, 7:19 PM
aacid added a subscriber: aacid.Dec 13 2019, 11:36 PM

this is binary incompatible.

Even the library is called libkdegaemsprivate, it's used "publicly" by some games, no need to break the binary compatibility "just because EBN says so" in my opinion

yurchor abandoned this revision.Dec 14 2019, 6:54 AM

Revision Contents
Changeset List

Diff 71466

View Options

libkdegamesprivate/kchatbasemodel.h

Loading...
View Options

libkdegamesprivate/kchatbasemodel.cpp

Loading...