Differential D2594

Add new session button to SessionsModel
ClosedPublic
Actions

Authored by davidedmundson on Aug 26 2016, 3:02 PM.

Details

Reviewers

mart

Group Reviewers

Plasma

Commits

R120:82b0aa2ada43: Add new session button to SessionsModel
R871:82b0aa2ada43: Add new session button to SessionsModel

Summary

This (optionally) appends an entry to the SessionsModel to append a "New
Session" option. The lock screen / user switcher are then modified to
use it.

Messages.sh is modified so all components are covered by the same pot.

Diff Detail

Repository

R120 Plasma Workspace

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

davidedmundson updated this revision to Diff 6305.Aug 26 2016, 3:02 PM

davidedmundson retitled this revision from to Add new session button to SessionsModel.

davidedmundson updated this object.

davidedmundson edited the test plan for this revision. (Show Details)

davidedmundson added a reviewer: Plasma.

Restricted Application added a project: Plasma. · View Herald TranscriptAug 26 2016, 3:02 PM

Restricted Application added a subscriber: plasma-devel. · View Herald Transcript

mart accepted this revision.Aug 26 2016, 3:27 PM

mart added a reviewer: mart.

mart added a subscriber: mart.

mart added inline comments.

components/CMakeLists.txt
2	unrelated?
components/sessionsprivate/CMakeLists.txt
20	in same commit as -DTRANSLATION_DOMAIN?

This revision is now accepted and ready to land.Aug 26 2016, 3:27 PM

davidedmundson added inline comments.Aug 26 2016, 3:41 PM

components/CMakeLists.txt
2	I was introducting i18n into components/sessionsprivate which previously didn't have it I didn't want to make a new .pot for 2 words, so I moved the -DTRANSLATION_DOMAN and Messages.sh from components/shellprivate -> components so that it covers all items in components.

Closed by commit R120:82b0aa2ada43: Add new session button to SessionsModel (authored by davidedmundson). · Explain WhyAug 27 2016, 6:38 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			components/CMakeLists.txt (4 lines)
V			components/{ ← shellprivate}/Messages.sh
M			components/sessionsprivate/CMakeLists.txt (1 line)
M			components/sessionsprivate/sessionsmodel.h (11 lines)
M			components/sessionsprivate/sessionsmodel.cpp (48 lines)
M			components/shellprivate/CMakeLists.txt (1 line)
V			components/{shellprivate → }/Messages.sh
M			lookandfeel/contents/components/UserList.qml (2 lines)
M			lookandfeel/contents/lockscreen/LockScreenUi.qml (1 line)
M			lookandfeel/contents/userswitcher/UserSwitcher.qml (2 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	6305	b20c896		Aug 26 2016, 3:02 PM	★	★
Diff 2	6326	40feeb4	rPLASMAWORKSPACE82b0aa2ada438d07a1b4cd8d7a8d8691450b45a2	Aug 27 2016, 6:37 PM	★	★