Differential D25882

Remove dynamic item creation in DefaultListItemBackground
ClosedPublic
Actions

Authored by ahiemstra on Dec 11 2019, 12:53 PM.

Details

Reviewers
mart
Group Reviewers
Kirigami
Commits
R169:48177613f2ca: Remove dynamic item creation in DefaultListItemBackground
Summary

For some unknown reason, DefaultListItemBackground uses dynamic item creation
instead of just declaring items for its separators. This patch removes the
dynamic item creation and just declares the separtor. This saves more than
1ms runtime per delegate that gets created in Kirigami Gallery's List View page,
reducing the time per delegate from more than 1ms to ~300us.

Test Plan

Kirigami Gallery's List View page still looks the same

Diff Detail

Repository
R169 Kirigami
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
ahiemstra created this revision.Dec 11 2019, 12:53 PM
Restricted Application added a project: Kirigami. · View Herald TranscriptDec 11 2019, 12:53 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
ahiemstra requested review of this revision.Dec 11 2019, 12:53 PM
mart accepted this revision.Dec 11 2019, 2:20 PM
This revision is now accepted and ready to land.Dec 11 2019, 2:20 PM
Closed by commit R169:48177613f2ca: Remove dynamic item creation in DefaultListItemBackground (authored by ahiemstra). · Explain WhyDec 12 2019, 4:53 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 71377

View Options

src/controls/private/DefaultListItemBackground.qml

Loading...