Differential D25868

[scenes/opengl] Remove glDrawBuffer call
ClosedPublic
Actions

Authored by romangg on Dec 11 2019, 3:33 AM.

Details

Reviewers
davidedmundson
Group Reviewers
KWin
Commits
R108:33bcc43fdf6c: [scenes/opengl] Remove glDrawBuffer call
Summary

According to Gl 3.2 (page 501) and 4.5 (page 204) specs the initial state of
the default framebuffer is already BACK. Therefore we do not need to set it
explicitly.

When we draw in the future to alternative framebuffers which do not have back
buffers this call is fatal.

Test Plan

No tearing on Wayland, tearing as before on X11.

Diff Detail

Repository
R108 KWin
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
romangg created this revision.Dec 11 2019, 3:33 AM
Restricted Application added a project: KWin. · View Herald TranscriptDec 11 2019, 3:33 AM
Restricted Application added a subscriber: kwin. · View Herald Transcript
romangg requested review of this revision.Dec 11 2019, 3:33 AM
davidedmundson accepted this revision.Dec 11 2019, 7:07 AM
This revision is now accepted and ready to land.Dec 11 2019, 7:07 AM
Closed by commit R108:33bcc43fdf6c: [scenes/opengl] Remove glDrawBuffer call (authored by romangg). · Explain WhyDec 11 2019, 2:47 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 71275

View Options

plugins/scenes/opengl/scene_opengl.cpp

Loading...