DiscardWindowPixmap when Surface size changes
ClosedPublic

Authored by graesslin on Aug 26 2016, 6:34 AM.

Details

Summary

So far this connect was only in ShellClient, but it's needed for all
Toplevels. Also when a XWayland window has it's surface size changed,
the pixmap needs to be discarded. Otherwise KWin might hit an assert
in AbstractEGLTexture due to the buffer having a different size than
the texture had previously.

Test Plan

Firefox, click download on bugreports.qt.io used to trigger
this for me. With this change no longer able to reproduce.

Diff Detail

Repository
R108 KWin
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
graesslin updated this revision to Diff 6283.Aug 26 2016, 6:34 AM
graesslin retitled this revision from to DiscardWindowPixmap when Surface size changes.
graesslin updated this object.
graesslin edited the test plan for this revision. (Show Details)
graesslin added reviewers: KWin, Plasma on Wayland.
Restricted Application added projects: Plasma on Wayland, KWin. · View Herald TranscriptAug 26 2016, 6:34 AM
Restricted Application added subscribers: kwin, plasma-devel. · View Herald Transcript
mart accepted this revision.Aug 26 2016, 9:01 AM
mart added a reviewer: mart.
This revision is now accepted and ready to land.Aug 26 2016, 9:01 AM
This revision was automatically updated to reflect the committed changes.