Differential D25819

Replace Q_DECL_OVERRIDE with override
ClosedPublic
Actions

Authored by nicolasfella on Dec 8 2019, 11:37 PM.

Details

Reviewers
staniek
Group Reviewers
Calligra: 3.0
Commits
R13:8f240fab40d1: Merge branch '3.2'
R13:fe1ec16a707d: Replace Q_DECL_OVERRIDE with override
Summary

It's the modern way of doing things

Test Plan

builds

Diff Detail

Repository
R13 KProperty
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
nicolasfella created this revision.Dec 8 2019, 11:37 PM
Restricted Application added a project: KProperty. · View Herald TranscriptDec 8 2019, 11:37 PM
Restricted Application added a subscriber: Kexi-Devel-list. · View Herald Transcript
nicolasfella requested review of this revision.Dec 8 2019, 11:37 PM
staniek accepted this revision.Dec 9 2019, 12:30 AM
staniek added a subscriber: staniek.

Looks good, thanks. We do that this way: apply to branch 3.2 and then merge 3.2 into master. Please ask if unsure.

This revision is now accepted and ready to land.Dec 9 2019, 12:30 AM
Closed by commit R13:fe1ec16a707d: Replace Q_DECL_OVERRIDE with override (authored by nicolasfella). · Explain WhyDec 9 2019, 9:28 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 71142

View Options

CMakeLists.txt

Loading...
View Options

src/editors/3rdparty/KColorCombo.h

Loading...
View Options

src/editors/3rdparty/KColorCombo.cpp

Loading...
View Options

src/editors/KPropertyMultiLineStringEditor.h

Loading...
View Options

src/editors/coloredit.h

Loading...