Differential D25761

Fix margins of ToolBarHeader
ClosedPublic
Actions

Authored by ahiemstra on Dec 5 2019, 12:24 PM.

Details

Reviewers
ngraham
Group Reviewers
Kirigami
Commits
R169:277fc7222021: Fix margins of ToolBarHeader
Summary

I apparently accidentally changed the toolbar header's left margin to
Units.smallSpacing instead of the original Units.largeSpacing. In
addition, in some cases, the ActionToolBar would have a double right
margin due to Layout.rightMargin.

Test Plan

Titles in Kirigami Gallery now have a 10px left margin

Diff Detail

Repository
R169 Kirigami
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
ahiemstra created this revision.Dec 5 2019, 12:24 PM
Restricted Application added a project: Kirigami. · View Herald TranscriptDec 5 2019, 12:24 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
ahiemstra requested review of this revision.Dec 5 2019, 12:24 PM
ngraham accepted this revision.Dec 5 2019, 3:47 PM
ngraham added a subscriber: ngraham.

Thanks!

This revision is now accepted and ready to land.Dec 5 2019, 3:47 PM
ngraham added a comment.Dec 5 2019, 8:12 PM

Would be good to land this before tagging in 2 days.

Closed by commit R169:277fc7222021: Fix margins of ToolBarHeader (authored by ahiemstra). · Explain WhyDec 5 2019, 8:31 PM
This revision was automatically updated to reflect the committed changes.

Showing Only Differences

This revision modifies 2 more files that are hidden because they were not modified between selected diffs and they have no inline comments.

Revision Contents
Changeset List

Path
No data available.

Diff 70979