Fix panelview config cleanup
ClosedPublic

Authored by davidedmundson on Aug 25 2016, 2:37 AM.

Details

Summary

Connecting to QObject::destroyed with Qt::QueuedConnection *should*
crash, when you use the object that's been deleted. it doesn't make any
logical sense.

The only reason it doesn't is because of another hack in Plasma-
framework where containment.cpp where containment emits
QObject::destroyed (yes really) before the actual destruction.

Unfortunately we can't fix the hack in frameworks till we fix this hack
round the original hack here.

This patch ports it to a different signal, which is emitted before
object teardown without hacks.

Test Plan

checked debug appeared when deleting a panel

Diff Detail

Repository
R120 Plasma Workspace
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
davidedmundson retitled this revision from to Fix panelview config cleanup.
davidedmundson updated this object.
davidedmundson edited the test plan for this revision. (Show Details)
davidedmundson added a reviewer: Plasma.
Restricted Application added a project: Plasma. · View Herald TranscriptAug 25 2016, 2:37 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
mart accepted this revision.Aug 25 2016, 8:16 AM
mart added a reviewer: mart.
This revision is now accepted and ready to land.Aug 25 2016, 8:16 AM
This revision was automatically updated to reflect the committed changes.