Differential D2563

Include KDECompilerSettings earlier to silence cmake warning
ClosedPublic
Actions

Authored by heikobecker on Aug 24 2016, 7:00 PM.

Details

Reviewers
davidedmundson
Group Reviewers
Plasma
Commits
R126:f24fb29f91fe: Include KDECompilerSettings earlier to silence cmake warning
Summary

It needs to be placed before find_package(KF5Init) in this case
because of KF5InitMacros. Otherwise I still get "CMake Warning (dev)
at /usr/host/lib/cmake/KF5Init/KF5InitMacros.cmake:43 (add_executable):
Policy CMP0063 is not set: Honor visibility properties for all target"
despite the NO_POLICY_SCOPE flag.

Test Plan

Warning disappears, still builds fine.

Diff Detail

Repository
R126 KDE CLI Utilities
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
heikobecker updated this revision to Diff 6238.Aug 24 2016, 7:00 PM
heikobecker retitled this revision from to Include KDECompilerSettings earlier to silence cmake warning.
heikobecker updated this object.
heikobecker edited the test plan for this revision. (Show Details)
heikobecker added a reviewer: Plasma.
Restricted Application added a project: Plasma. · View Herald TranscriptAug 24 2016, 7:00 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
davidedmundson accepted this revision.Aug 24 2016, 8:51 PM
davidedmundson added a reviewer: davidedmundson.
This revision is now accepted and ready to land.Aug 24 2016, 8:51 PM
Closed by commit R126:f24fb29f91fe: Include KDECompilerSettings earlier to silence cmake warning (authored by heikobecker). · Explain WhyAug 24 2016, 10:31 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
MCMakeLists.txt (2 lines)

Diff 6244

View Options

CMakeLists.txt

Loading...