Differential D2558

[Lock Screen] Connect to resetPassword signal
ClosedPublic
Actions

Authored by broulik on Aug 24 2016, 1:57 PM.

Details

Reviewers
davidedmundson
Group Reviewers
Plasma: Design
Plasma
Commits
R871:70d3ec9f724b: [Lock Screen] Connect to resetPassword signal
R120:70d3ec9f724b: [Lock Screen] Connect to resetPassword signal
Summary

Focus is drawn away from the TextField when requesting unlock to work around a Qt bug.
However, when unlocking fails, the focus is not restored to the TextField.

Also, select all in the TextField in this case so you can quickly type anew and disable it
while grace locked.

Test Plan

Locked screen, typed in some rubbish, pressed return, typed in proper password, pressed return, session unlocked

Diff Detail

Repository
R120 Plasma Workspace
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
broulik updated this revision to Diff 6221.Aug 24 2016, 1:57 PM
broulik retitled this revision from to [Lock Screen] Focus password field and select all on failure.
broulik updated this object.
broulik edited the test plan for this revision. (Show Details)
broulik added reviewers: Plasma, Plasma: Design.
broulik set the repository for this revision to R120 Plasma Workspace.
Restricted Application added a project: Plasma. · View Herald TranscriptAug 24 2016, 1:57 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
davidedmundson accepted this revision.Aug 24 2016, 1:59 PM
davidedmundson added a reviewer: davidedmundson.
This revision is now accepted and ready to land.Aug 24 2016, 1:59 PM
broulik abandoned this revision.Aug 24 2016, 2:00 PM
broulik updated this revision to Diff 6222.Aug 24 2016, 2:06 PM
broulik retitled this revision from [Lock Screen] Focus password field and select all on failure to [Lock Screen] Connect to resetPassword signal.
broulik updated this object.
broulik edited edge metadata.
This revision is now accepted and ready to land.Aug 24 2016, 2:06 PM
Closed by commit R120:70d3ec9f724b: [Lock Screen] Connect to resetPassword signal (authored by broulik). · Explain WhyAug 24 2016, 2:13 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 6223

View Options

lookandfeel/contents/lockscreen/MainBlock.qml

Loading...