[Notifications] Move out of the way of dialog rather than just hiding
ClosedPublic

Authored by broulik on Wed, Nov 27, 3:48 PM.

Details

Summary

When e.g. connecting to a network with captive portal, it leaves you sitting there wondering what's going on. The notification won't time out until it becomes visible again but still there's been complaints that the notifications go missing.
This patch makes them move out of the way vertically. It is pretty crude but covers the majority ("System Tray covers notifications") case.

Test Plan


When there's many notifications, it can look a bit odd as they move down and then the lower part is hidden as notifications may only occupy 2/3 of vertical height even when shifted.
Didn't test what happens if you have a giant notification on a small screen, it will probably end up partially off screen
Could also be odd now if you open notification history, you'll see your notifications twice I guess

Diff Detail

Repository
R120 Plasma Workspace
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
broulik created this revision.Wed, Nov 27, 3:48 PM
Restricted Application added a project: Plasma. · View Herald TranscriptWed, Nov 27, 3:48 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
broulik requested review of this revision.Wed, Nov 27, 3:48 PM
broulik edited the test plan for this revision. (Show Details)Wed, Nov 27, 3:51 PM

Nice, this works great. Just what I would expect.

ngraham accepted this revision as: VDG.Wed, Nov 27, 5:38 PM
This revision was not accepted when it landed; it landed in state Needs Review.Fri, Nov 29, 12:34 PM
This revision was automatically updated to reflect the committed changes.