Differential D2555

Use signal screenRemoved instead of QObject::destroyed
ClosedPublic
Actions

Authored by davidedmundson on Aug 24 2016, 12:34 PM.

Details

Reviewers
apol
Group Reviewers
Plasma
Commits
R133:53b2e614ce9e: Use signal screenRemoved instead of QObject::destroyed
Summary

Considerably less messy as you don't end up processing a screenChanged()
on the about to be deleted screen.

Diff Detail

Repository
R133 KScreenLocker
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
davidedmundson updated this revision to Diff 6214.Aug 24 2016, 12:34 PM
davidedmundson retitled this revision from to Use signal screenRemoved instead of QObject::destroyed.
davidedmundson updated this object.
davidedmundson edited the test plan for this revision. (Show Details)
davidedmundson added a reviewer: Plasma.
Restricted Application added a project: Plasma. · View Herald TranscriptAug 24 2016, 12:34 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
apol accepted this revision.Aug 24 2016, 1:23 PM
apol added a reviewer: apol.
This revision is now accepted and ready to land.Aug 24 2016, 1:23 PM
Closed by commit R133:53b2e614ce9e: Use signal screenRemoved instead of QObject::destroyed (authored by davidedmundson). · Explain WhyAug 24 2016, 1:28 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mgreeter/greeterapp.cpp (3 lines)

Diff 6218

View Options

greeter/greeterapp.cpp

Loading...