Differential D25437

Port to QTextBrowser
ClosedPublic
Actions

Authored by cordlandwehr on Nov 21 2019, 11:56 AM.

Details

Reviewers

yurchor

Maniphest Tasks

T11574: Port Kiten away from KHTML

Commits

R332:b0266cb89d23: Port to QTextBrowser

Summary

This ports away from the KHTML dependency. Note that QTextBrowser
does not support CSS pseudo class selectors, which means that the
hover property cannot be set for CSS elements. Thus the results view
is changed such that the light-gray background is not bound to the
hovering of a mouse courser but is applied to every odd line.

Diff Detail

Repository

R332 Kiten

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

cordlandwehr created this revision.Nov 21 2019, 11:56 AM

Restricted Application added a project: KDE Edu. · View Herald TranscriptNov 21 2019, 11:56 AM

Restricted Application added a subscriber: kde-edu. · View Herald Transcript

cordlandwehr requested review of this revision.Nov 21 2019, 11:56 AM

Harbormaster completed remote builds in B19020: Diff 70099.Nov 21 2019, 11:56 AM

Kiten after porting:

Kiten before porting:

cordlandwehr added a task: T11574: Port Kiten away from KHTML.Nov 21 2019, 11:59 AM

Compiles, installs and works as expected.

This revision is now accepted and ready to land.Nov 21 2019, 12:20 PM

Closed by commit R332:b0266cb89d23: Port to QTextBrowser (authored by cordlandwehr). · Explain WhyNov 21 2019, 12:21 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			CMakeLists.txt (12 lines)
M			app/CMakeLists.txt (17 lines)
M			app/kiten.cpp (7 lines)
M			app/resultsview.h (11 lines)
M			app/resultsview.cpp (78 lines)
M			lib/entrylist.cpp (3 lines)