Added animation on background color change.
Removed test for background color that is not needed any more.
BUG:414174
FIXED-IN:0.9.5
Added animation on background color change.
Removed test for background color that is not needed any more.
BUG:414174
FIXED-IN:0.9.5
Automatic diff as part of commit; lint not applicable. |
Automatic diff as part of commit; unit tests not applicable. |
There is no need to set BG to transparent if "busyBackground || coloredView" is false, because in this case, opacity will be at 0.
BG transition must be smooth when colorizerManager changes color though, so it needs its separate animation. (transition from plasma reverse to window color for instance)
Also, leaving the background set to transparent piece of code AND adding the animation would speed up the disappearance of the panel (in case of hide bg when not needed) and the animation for fade in and fade out would not have the same duration.
@acemond forget my previous comment... background transition works much better with your commit...
do you have commit access?
I just registered to Phabricator so I'm pretty sure that if you feel the need to ask me that, then the answer is probably no :)
I added myself to the project but I still don't see any way to commit. Maybe I should have used arc from the beginning?
@acemond you need to wait for @mvourlakos to commit the change. You should also provide your authorship information name and email address.
@ognarb ok I'll look into that. Maybe I should read the instructions or tutorials provided on Phabricator. For now I only added them to my profile.
But maybe you meant you needed them here.
author: Adrien Brunelat
email: ad**en.br****at@gmail.com