Differential D25373

Remove dead QCalendarSystem code
Needs ReviewPublic
Actions

Authored by vkrause on Nov 18 2019, 5:43 PM.
This revision needs review, but there are no reviewers specified.

Details

Reviewers
None

Diff Detail

Repository
R81 KDE PIM Addons
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 18913
Build 18931: arc lint + arc unit
vkrause created this revision.Nov 18 2019, 5:43 PM
Restricted Application added a project: KDE PIM. · View Herald TranscriptNov 18 2019, 5:43 PM
Restricted Application added a subscriber: kde-pim. · View Herald Transcript
vkrause requested review of this revision.Nov 18 2019, 5:43 PM
winterz added a subscriber: winterz.Nov 18 2019, 7:54 PM

Volker, if you do this:
remove the commented 'add_subdirectory(hebrew) ' line from korganizer/plugins/CMakelists.txt along with the entire plugins/hebrew subdirectory

even better would be if someone would port the kdelibs4support KCalendarSystem to frameworks and then we could resurrect the Hebrew plugin.

vkrause added a comment.Nov 18 2019, 8:15 PM

Looking into porting away from kdelibs4support is what got me here, yes. However I don't see how this code is used right now, nor do I see how it might help in porting, as it doesn't actually contain the implementation of the Hebrew calendar math it seems?

Revision Contents
Changeset List

Diff 69943

View Options

korganizer/plugins/hebrew/CMakeLists.txt

Loading...
View Options

korganizer/plugins/hebrew/qcalendarsystem.cpp

Loading...
View Options

korganizer/plugins/hebrew/qcalendarsystem_p.h

Loading...