Differential D25181

Properly initialize ExceptionInfo in libMagick
ClosedPublic
Actions

Authored by arojas on Nov 6 2019, 10:39 PM.

Details

Reviewers
cgilles
Group Reviewers
Digikam
Commits
R482:76ff65aec63b: Properly initialize ExceptionInfo in libMagick
Summary

Otherwise it will crash if some plugins can't be loaded. See upstream report https://github.com/ImageMagick/ImageMagick/issues/1776

Test Plan

Builds, doesn't crash when some IM plugin can't be loaded due to missing shared libraries

Diff Detail

Repository
R482 digiKam
Lint
Lint Skipped
Unit
Unit Tests Skipped
arojas requested review of this revision.Nov 6 2019, 10:39 PM
arojas created this revision.
cgilles accepted this revision.Nov 7 2019, 3:42 AM
cgilles added a subscriber: cgilles.

Changes are fine to be applied to git/master

Gilles Caulier

This revision is now accepted and ready to land.Nov 7 2019, 3:42 AM
Closed by commit R482:76ff65aec63b: Properly initialize ExceptionInfo in libMagick (authored by arojas). · Explain WhyNov 7 2019, 8:26 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 69365

View Options

core/dplugins/dimg/imagemagick/dimgimagemagickplugin.cpp

Loading...
View Options

core/tests/dimg/magickloader.cpp

Loading...