fix(kded): read rotated output size
ClosedPublic

Authored by romangg on Tue, Oct 29, 10:31 PM.

Details

Summary

When adjusting positions on config read respect the rotation value on reading
in the output size.

BUG: 413627
CCBUG: 396354
FIXED-IN: 5.17.3

Test Plan

User tested it on a setup with one rotated output and two non-rotated outputs.

Diff Detail

Repository
R104 KScreen
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
romangg created this revision.Tue, Oct 29, 10:31 PM
Restricted Application added a project: Plasma. · View Herald TranscriptTue, Oct 29, 10:31 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
romangg requested review of this revision.Tue, Oct 29, 10:31 PM
romangg edited the summary of this revision. (Show Details)Wed, Oct 30, 1:06 PM
gmassullo added a subscriber: gmassullo.EditedThu, Nov 7, 11:56 AM

I tested this patch on Plasma 5.17.2 [1] and it fixes
Screens overlapping after screen lock

I would like to give a comment about the following KDE bugreports, even if they may be not related: I am not yet sure, but I think that it also has fixed
"show only application on current screen" shows no applications
Second screen rotated triggers Okular to appear on primary screen exceeding borders
Second screen rotated triggers Gwenview to appear on primary screen exceeding borders
I will keep testing them.

The following bug instead still happens
Second screen rotated triggers Ark to appear on primary screen exceeding borders

[1]: https://copr.fedorainfracloud.org/coprs/germano/kscreen

davidedmundson accepted this revision.Fri, Nov 8, 9:38 AM
davidedmundson added a subscriber: davidedmundson.

I don't follow why this bug was only newly introduced, but this does seem to make sense.

This revision is now accepted and ready to land.Fri, Nov 8, 9:38 AM
This revision was automatically updated to reflect the committed changes.