Differential D25033

Extract images from excel files which omit the FtCF entry.
ClosedPublic
Actions

Authored by denexter on Oct 29 2019, 6:34 AM.

Details

Reviewers
pvuorela
Commits
R8:b253bef8dc85: Extract images from excel files which omit the FtCF entry.
Summary

The specification says it and the flags entry must exist if the object type is picture but appears to not be true of some files. Since there's no essential information there add a basic check for the field id and if it not what is expected skip parsing of that field without invalidating the entire object.

Diff Detail

Repository
R8 Calligra
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
denexter created this revision.Oct 29 2019, 6:34 AM
Restricted Application added a project: Calligra: 3.0. · View Herald TranscriptOct 29 2019, 6:34 AM
Restricted Application added a subscriber: Calligra-Devel-list. · View Herald Transcript
denexter requested review of this revision.Oct 29 2019, 6:34 AM
pvuorela accepted this revision.Nov 7 2019, 9:48 AM

Minor comment, but overall looks good to me.

filters/sheets/excel/sidewinder/excel.cpp
1421

Minor, but this line can be removed now?

This revision is now accepted and ready to land.Nov 7 2019, 9:48 AM
Closed by commit R8:b253bef8dc85: Extract images from excel files which omit the FtCF entry. (authored by denexter, committed by pvuorela). · Explain WhyNov 11 2019, 9:21 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 69569

View Options

filters/sheets/excel/sidewinder/excel.cpp

Loading...