KOrganizer Agenda View: Compute Grid Lines Color
AbandonedPublic

Authored by winterz on Oct 27 2019, 8:04 PM.

Details

Reviewers
mlaurent
ognarb
Summary

Always compute the grid lines colors as a function of the palette's windowtext color.
Don't be concerned if the windowtext color is from the system or custom.
note that that we don't permit custom changing of the windowtext color . we can only allow changing the background colors.

https://bugs.kde.org/show_bug.cgi?id=411608

Test Plan

tried various color combinations and using system colors and not using system colors.
appreciate other testers since I don't use dark theme

Diff Detail

Repository
R210 KOrganizer
Lint
Lint Skipped
Unit
Unit Tests Skipped
winterz created this revision.Oct 27 2019, 8:04 PM
Restricted Application added a project: KDE PIM. · View Herald TranscriptOct 27 2019, 8:04 PM
Restricted Application added a subscriber: kde-pim. · View Herald Transcript
winterz requested review of this revision.Oct 27 2019, 8:04 PM
winterz added a reviewer: mlaurent.
winterz edited the summary of this revision. (Show Details)Oct 27 2019, 8:29 PM
ognarb accepted this revision.Oct 27 2019, 8:31 PM
ognarb added a subscriber: ognarb.

I probably didn't test with enough color scheme when I wrote this code ;)

This revision is now accepted and ready to land.Oct 27 2019, 8:31 PM
mlaurent requested changes to this revision.Oct 28 2019, 7:29 AM
mlaurent added inline comments.
src/agenda/agenda.cpp
1670

Fix indent

This revision now requires changes to proceed.Oct 28 2019, 7:29 AM
winterz updated this revision to Diff 69594.EditedNov 11 2019, 5:07 PM

I just committed this e031408f12dadff675a92a06eb9449a52e78d124
sorry I forgot to wait for the final review

can someone approve so we can close?

winterz abandoned this revision.Nov 16 2019, 3:04 PM

abandoning.
however, this was committed in e031408f12dadff675a92a06eb9449a52e78d124
sorry I forgot to wait for the final review