Differential D2492

[Panel Containment] Cleanup
ClosedPublic
Actions

Authored by broulik on Aug 18 2016, 9:18 PM.

Details

Reviewers
mart
Group Reviewers
Plasma
Commits
R119:50dc4358753f: [Panel Containment] Cleanup
Summary
  • When creating the applet container set as many properties initially as you can (today I learned: Qt.binding works in there too)
  • Use Qt.binding for configure action visibility/enabledness
  • Cache array lengths and lookups in loops (unfortunately QML list basic type behaves widely different from a JS Array and has none of its fancy "some" and "forEach" functions)
  • Remove unused variables
Test Plan

Panel still works.
Verified the binding with HiddenStatus still works, ie. pager is invisible with just one virtual desktop but shows up when panel controller opens.

Diff Detail

Repository
R119 Plasma Desktop
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
broulik updated this revision to Diff 6048.Aug 18 2016, 9:18 PM
broulik retitled this revision from to [Panel Containment] Cleanup.
broulik updated this object.
broulik edited the test plan for this revision. (Show Details)
broulik added a reviewer: Plasma.
broulik set the repository for this revision to R119 Plasma Desktop.
Restricted Application added a project: Plasma. · View Herald TranscriptAug 18 2016, 9:18 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
mart accepted this revision.Aug 18 2016, 10:03 PM
mart added a reviewer: mart.
This revision is now accepted and ready to land.Aug 18 2016, 10:03 PM
Closed by commit R119:50dc4358753f: [Panel Containment] Cleanup (authored by broulik). · Explain WhyAug 19 2016, 8:53 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 6066

View Options

containments/panel/contents/ui/main.qml

Loading...