fix layout of grid&guide docker (grid portion)
ClosedPublic

Authored by tpaulssen on Aug 18 2016, 4:21 PM.

Details

Reviewers
scottpetrovic
Summary

moves the aspect ratio button for offsets to the right of
the spin boxes

puts almost all widgets into a single GridLayout

reorganizes the items in the code to correspond to their order
in the grid

Test Plan
  • make sure the grids & guides docker is visible
  • select the "grids" tab in the docker
  • toggle the "grid offset" checkbox
  • note whether the "chain"/"link" button for the offset appears to the right of the two input boxes for the offset or above both of them

for the reorganization portion:

  • open the grids and guides docker .ui file in the editor
  • go through the items in the tree
  • note whether the order is a jumbled mess or organized by row and column

Diff Detail

Repository
R37 Krita
Lint
Lint Skipped
Unit
Unit Tests Skipped
tpaulssen updated this revision to Diff 6037.Aug 18 2016, 4:21 PM
tpaulssen retitled this revision from to fix layout of grid&guide docker (grid portion).
tpaulssen updated this object.
tpaulssen edited the test plan for this revision. (Show Details)
tpaulssen added a reviewer: scottpetrovic.
tpaulssen set the repository for this revision to R37 Krita.
tpaulssen added a comment.EditedAug 18 2016, 4:26 PM

before:

after:

behaviour when shrinking the docker ...

before:

after:

note that in the "before" window you have to resize the docker a bit vertically so that the chain-link "lock aspect ratio" button even appears

I built and it seems alright to me. It looks like it is just tweaking where things are at a bit

scottpetrovic accepted this revision.Aug 18 2016, 11:09 PM
scottpetrovic edited edge metadata.
This revision is now accepted and ready to land.Aug 18 2016, 11:09 PM
scottpetrovic closed this revision.Aug 7 2017, 11:18 PM

pretty sure this is done... closing.