[Windows Runner] Gather window again when running result
ClosedPublic

Authored by broulik on Oct 22 2019, 7:56 AM.

Details

Summary

Since we fixed RunnerManager::teardown to actually be emitted, the runner would throw away its gathered window info and then crash in run().
I couldn't figure out what the proper API was so this is a workaround to keep it from crashing at least.
However, the runner also didn't check whether the window was actually still valid by the time run() was called, so querying for the window again once it is called and checking validity is a good thing either way imho.
In the future, this probably should be ported to using libtaskmanager :)

BUG: 412386
FIXED-IN: 5.17.1

Test Plan
  • Can activate windows fine again without crashing

Diff Detail

Repository
R120 Plasma Workspace
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
broulik created this revision.Oct 22 2019, 7:56 AM
Restricted Application added a project: Plasma. · View Herald TranscriptOct 22 2019, 7:56 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
broulik requested review of this revision.Oct 22 2019, 7:56 AM
davidedmundson accepted this revision.Oct 22 2019, 8:58 AM
This revision is now accepted and ready to land.Oct 22 2019, 8:58 AM
This revision was automatically updated to reflect the committed changes.