Differential D24801

Cleanup icon handling
ClosedPublic
Actions

Authored by vkrause on Oct 20 2019, 11:17 AM.

Details

Reviewers
mlaurent
Maniphest Tasks
T11637: KIconThemes Cleanups
Commits
R210:21b779358339: Cleanup icon handling
Summary
  • Remove unnecessary KIconLoader search paths
  • Prefer QStyle over KIconLoader for determining sizes
  • Prefer icons over pixmaps on QActions

Diff Detail

Repository
R210 KOrganizer
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 17928
Build 17946: arc lint + arc unit
vkrause created this revision.Oct 20 2019, 11:17 AM
Restricted Application added a project: KDE PIM. · View Herald TranscriptOct 20 2019, 11:17 AM
Restricted Application added a subscriber: kde-pim. · View Herald Transcript
vkrause requested review of this revision.Oct 20 2019, 11:17 AM
mlaurent accepted this revision.Oct 20 2019, 2:21 PM
This revision is now accepted and ready to land.Oct 20 2019, 2:21 PM
Closed by commit R210:21b779358339: Cleanup icon handling (authored by vkrause). · Explain WhyOct 20 2019, 2:48 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 68349

View Options

src/kontactplugin/korganizer/CMakeLists.txt

Loading...
View Options

src/kontactplugin/korganizer/apptsummarywidget.cpp

Loading...
View Options

src/kontactplugin/korganizer/journalplugin.cpp

Loading...
View Options

src/kontactplugin/korganizer/korganizerplugin.cpp

Loading...
View Options

src/kontactplugin/korganizer/todoplugin.cpp

Loading...
View Options

src/kontactplugin/korganizer/todosummarywidget.cpp

Loading...
View Options

src/kontactplugin/specialdates/CMakeLists.txt

Loading...
View Options

src/kontactplugin/specialdates/sdsummarywidget.cpp

Loading...
View Options

src/widgets/navigatorbar.cpp

Loading...