Serializing the desktop layout to a JavaScript object
ClosedPublic
Actions

Authored by ivan on Aug 18 2016, 12:06 PM.

Details

Reviewers

Group Reviewers

Commits

Summary

Repository

R120 Plasma Workspace

Branch

ivan/separateLookAndFeelLayoutSerialization

Lint

No Linters Available

Unit

No Unit Test Coverage

ivan retitled this revision from to Serializing the desktop layout to a JavaScript object.

ivan updated this object.

ivan edited the test plan for this revision. (Show Details)

ivan added reviewers: Plasma, mart.

Restricted Application added a subscriber: plasma-devel. · View Herald Transcript

mart edited edge metadata.

mart added inline comments.

shell/scripting/scriptengine_v1.cpp
345	clear it from dead code
615	dead code
shell/shellcorona.cpp
392	QByteArray and returning .toUtf8()?

This revision is now accepted and ready to land.Aug 18 2016, 12:32 PM

shell/shellcorona.cpp
392	toJson is already utf8 byte array

			Path	Packages
M			shell/CMakeLists.txt (1 line)
M			shell/dbus/org.kde.PlasmaShell.xml (3 lines)
P			shell/scripting/scriptengine.h (35 lines) Copied to shell/scripting/scriptengine_v1.h
P			shell/scripting/scriptengine.cpp (889 lines) Copied to shell/scripting/scriptengine_v1.cpp
P			shell/scripting/scriptengine_v1.h (57 lines) Copied from shell/scripting/scriptengine.h
P			shell/scripting/scriptengine_v1.cpp (654 lines) Copied from shell/scripting/scriptengine.cpp
M			shell/shellcorona.h (2 lines)
M			shell/shellcorona.cpp (338 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	6026	41f5431		Aug 18 2016, 12:06 PM	★	★
Diff 2	6028	41f5431	- Dumping JS as a UTF8 byte array instead as a string	Aug 18 2016, 12:57 PM	★	★

Commit	Tree	Parents	Author	Summary	Date
8a1b956c48b1	fdf2957df08d	fbd541034696	Ivan Čukić	Dumping JS as a UTF8 byte array instead as a string	Aug 18 2016, 12:56 PM
fbd541034696	3345e64b584a	9e8eddcc4378 41f54319fc4a	Ivan Čukić	Serializing the desktop layout to a JavaScript object (Show More…)	Aug 18 2016, 12:04 PM
9e8eddcc4378	564fd25a2e9f	63dd5718ffe3	Ivan Čukić	Disabled the debugging output	Aug 17 2016, 9:19 AM
63dd5718ffe3	922a6f6480ef	faa512026689	Ivan Čukić	Loading the panels	Aug 17 2016, 9:16 AM
faa512026689	ac59e8f666e7	09e6a71bd33d	Ivan Čukić	Splitting V1 scripting functions into a separate class and file	Aug 17 2016, 8:30 AM
09e6a71bd33d	76e464786912	cdda3668753e	Ivan Čukić	Added debugging output just for comparison with regular layout.js	Aug 16 2016, 11:25 PM
cdda3668753e	f7df0ff63fe2	305a66648c8a	Ivan Čukić	Loading the desktop from the serialized data	Aug 16 2016, 11:17 PM
305a66648c8a	bde6b0a10780	735cf7429333	Ivan Čukić	Introducing the mechanism for the future API versioning	Aug 16 2016, 8:44 PM
735cf7429333	8a4518854a7a	d21935382c7a	Ivan Čukić	Support for different config groups	Aug 16 2016, 7:40 PM
d21935382c7a	d13f8347b0a6	e7ce23c44911	Ivan Čukić	Serializing the desktop layout for current activity	Aug 16 2016, 7:13 PM
e7ce23c44911	18104e8a51c3	3476cf0c53c8 2c868c438033	Ivan Čukić	Merge branch 'master' into ivan/separateLookAndFeelLayoutSerialization	Aug 16 2016, 4:06 PM