Differential D24754

Fix KNSCore::Cache fetching when initialising Engine
ClosedPublic
Actions

Authored by leinir on Oct 18 2019, 11:04 AM.

Details

Reviewers
rikmills
Group Reviewers
Frameworks
KNewStuff
Commits
R304:8977627cab85: Fix KNSCore::Cache fetching when initialising Engine
Summary

During the moving-around of the config files, the Cache was left
behind unfixed, and we ended up with all caches being the same,
because we attempted to request a cache for a config file which
was not found, and consequently resulted in the requested cache
being named "", which consequently failed rather badly.

BUG:408716

Diff Detail

Repository
R304 KNewStuff
Branch
fix-knscore-cache (branched from master)
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 17890
Build 17908: arc lint + arc unit
leinir created this revision.Oct 18 2019, 11:04 AM
Restricted Application added a project: Frameworks. · View Herald TranscriptOct 18 2019, 11:04 AM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
leinir requested review of this revision.Oct 18 2019, 11:04 AM
leinir updated this revision to Diff 68227.Oct 18 2019, 11:06 AM
  • Revert unrelated change
rikmills added a comment.Oct 18 2019, 1:47 PM

Patched knewstuff build with this and tested. Switching between KCMs in systemsettings now seems to pull the correct KNS results.

rikmills accepted this revision.Oct 18 2019, 1:48 PM
This revision is now accepted and ready to land.Oct 18 2019, 1:48 PM
leinir updated this revision to Diff 68284.Oct 19 2019, 9:19 AM
  • Ensure that the config filename only has the base name
Closed by commit R304:8977627cab85: Fix KNSCore::Cache fetching when initialising Engine (authored by leinir). · Explain WhyOct 21 2019, 8:08 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/core/engine.cpp (5 lines)

Diff 68284

View Options

src/core/engine.cpp

Loading...