Differential D24745

Add Icon to Executable and Restrict GNUCXX compiler options
ClosedPublic
Actions

Authored by twighk on Oct 17 2019, 7:48 PM.

Details

Reviewers
aacid
Group Reviewers
KDE Games
Commits
R425:a5c880b334d5: Add Icon to Executable and Restrict GNUCXX compiler options
R425:41415281cf03: Add Icon to Executable and Restrict GNUCXX compiler options
Summary

Icons missing from executable on windows.

Fix compilation on MSVC by restricting -W like compiler flags to GNUCXX

Diff Detail

Repository
R425 Knights
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
twighk requested review of this revision.Oct 17 2019, 7:48 PM
twighk created this revision.
twighk retitled this revision from Add Icon to Executable and Restrict GNUGXX compiler options to Add Icon to Executable and Restrict GNUCXX compiler options.Oct 17 2019, 8:27 PM
twighk edited the summary of this revision. (Show Details)
aacid accepted this revision.Oct 17 2019, 9:38 PM
aacid added a subscriber: aacid.

-Wall -Wextra -Wcast-align -Wchar-subscripts -Wformat-security -Wno-long-long -Wpointer-arith -Wundef -fno-exceptions are added by default by ecm so it's not that even we need to list them here.

This revision is now accepted and ready to land.Oct 17 2019, 9:38 PM
twighk updated this revision to Diff 68267.Oct 18 2019, 9:59 PM

Remove extra flags

Closed by commit R425:41415281cf03: Add Icon to Executable and Restrict GNUCXX compiler options (authored by twighk). · Explain WhyOct 18 2019, 10:54 PM
This revision was automatically updated to reflect the committed changes.
aacid added a comment.Oct 20 2019, 5:19 PM

Any reason you commited the arcpatch-D24745 branch to git?

twighk added a comment.Oct 20 2019, 5:23 PM

That would have been a mistake, as i'm not completely sure on what i'm doing.

aacid added a comment.Oct 20 2019, 5:27 PM

Ok, i have removed the arcpatch-D24745 branch from the git repo.

Please ask if you have questions

Showing Only Differences

This revision modifies 3 more files that are hidden because they were not modified between selected diffs and they have no inline comments.

Revision Contents
Changeset List

Path
No data available.

Diff 68274