Differential D24721

Show backend name and version in app delegates
Needs RevisionPublic
Actions

Authored by brunogoncalves on Oct 17 2019, 3:51 AM.

Details

Reviewers
ngraham
Group Reviewers
Discover Software Store
Summary

Separates appstream, flatpak and snap packages, also informs package version and package type next to name.

FEATURE: 399530

Test Plan

Diff Detail

Repository
R134 Discover Software Store
Lint
Lint Skipped
Unit
Unit Tests Skipped
brunogoncalves created this revision.Oct 17 2019, 3:51 AM
Restricted Application added a project: Plasma. · View Herald TranscriptOct 17 2019, 3:51 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
brunogoncalves requested review of this revision.Oct 17 2019, 3:51 AM
ngraham retitled this revision from Bug 399530 to Show backend name and version in app delegates.Oct 17 2019, 3:16 PM
ngraham edited the summary of this revision. (Show Details)
ngraham edited the test plan for this revision. (Show Details)
ngraham requested changes to this revision.Oct 17 2019, 4:02 PM

I like the idea behind this but I'm not sure this is the right way to do it. Instead of changing the strings in the backend, we should add the new text (plus icons, preferably) on the UI side, in the QML files. See discover/qml/ApplicationDelegate.qml

This revision now requires changes to proceed.Oct 17 2019, 4:02 PM
ngraham added a comment.May 19 2020, 1:33 PM

Ping! This is an important thing to have overall; could you please submit it as a Merge Request at https://invent.kde.org/plasma/discover/-/merge_requests?

Thanks!

Revision Contents
Changeset List

Diff 68107

View Options

libdiscover/backends/FlatpakBackend/FlatpakResource.cpp

Loading...
View Options

libdiscover/backends/PackageKitBackend/AppPackageKitResource.cpp

Loading...
View Options

libdiscover/backends/SnapBackend/SnapResource.cpp

Loading...