Use ECMGenerateExportHeader to manage deprecated API better
ClosedPublic
Actions

Authored by kossebau on Oct 16 2019, 8:06 PM.

Details

Reviewers

mlaurent

Group Reviewers

Frameworks

Commits

Summary

Allows

projects linking to KEmoticons to hide deprecated API up to a given version or silence deprecation warnings after a given version, using
- -DKEMOTICONS_DISABLE_DEPRECATED_BEFORE_AND_AT
- -DKEMOTICONS_NO_DEPRECATED
- -DKEMOTICONS_DEPRECATED_WARNINGS_SINCE
- -DKEMOTICONS_NO_DEPRECATED_WARNINGS
  
  or (once enabled when all KF modules are done)
- -DKF_DISABLE_DEPRECATED_BEFORE_AND_AT
- -DKF_NO_DEPRECATED
- -DKF_DEPRECATED_WARNINGS_SINCE
- -DKF_NO_DEPRECATED_WARNINGS
to build KEmoticons optionally with deprecated API excluded from the build, using "EXCLUDE_DEPRECATED_BEFORE_AND_AT" cmake argument.

Test Plan

Builds with EXCLUDE_DEPRECATED_BEFORE_AND_AT set to 0, 5.0.0, CURRENT.

Repository

R301 KEmoticons

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript

kossebau requested review of this revision.Oct 16 2019, 8:06 PM

This revision is now accepted and ready to land.Oct 17 2019, 4:53 AM

This revision was automatically updated to reflect the committed changes.

			Path	Packages
M			CMakeLists.txt (5 lines)
M			src/core/CMakeLists.txt (9 lines)
M			src/core/kemoticonsprovider.h (30 lines)
M			src/core/kemoticonsprovider.cpp (12 lines)
M			src/core/kemoticonstheme.h (30 lines)
M			src/core/kemoticonstheme.cpp (10 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	68082	872eb72		Oct 16 2019, 8:06 PM	★	★
Diff 2	68146	872eb72	R301:2f0fffb706048fa5e5ef17ee698c72ca94482a1b	Oct 17 2019, 1:49 PM	★	★

Commit	Tree	Parents	Author	Summary	Date
ed1da3d1140b	67e2567ee522	872eb726d391	Friedrich W. H. Kossebau	Use ECMGenerateExportHeader to manage deprecated API better (Show More…)	Oct 16 2019, 8:05 PM