[kdevplatform] sort documentation providers list in documentation view;
ClosedPublic

Authored by antonanikin on Aug 16 2016, 10:14 AM.

Details

Summary

This patch performs sorting of documentation providers list in documentation view. Unsorted list is ugly and blocks comfortable finding of documentation sections.

Diff Detail

Repository
R33 KDevPlatform
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
antonanikin retitled this revision from to [kdevplatform] sort documentation providers list in documentation view;.
antonanikin updated this object.
antonanikin edited the test plan for this revision. (Show Details)
antonanikin added reviewers: KDevelop, kfunk.
antonanikin set the repository for this revision to R33 KDevPlatform.
Restricted Application added a subscriber: kdevelop-devel. · View Herald TranscriptAug 16 2016, 10:14 AM
mwolff accepted this revision.Aug 16 2016, 3:59 PM
mwolff added a reviewer: mwolff.
mwolff added a subscriber: mwolff.

lgtm

This revision is now accepted and ready to land.Aug 16 2016, 3:59 PM
kfunk requested changes to this revision.Aug 20 2016, 2:33 PM
kfunk edited edge metadata.

This isn't a good place to do the sorting. mProviders is modified in several other places as well (with the resp. QAIM {begin,end}... methods being called as well).

Do that in a QSortFilterProxyModel instead?

This revision now requires changes to proceed.Aug 20 2016, 2:33 PM
antonanikin edited edge metadata.

Do that in a QSortFilterProxyModel instead?

I think it's 'overkill' method for this problem. New version of ProvidersModel provide sorted mProviders list during object's lifetime.

kfunk accepted this revision.Aug 25 2016, 8:52 PM
kfunk edited edge metadata.

Okay, with the extra function addProvider this looks clean enough for me.

This revision is now accepted and ready to land.Aug 25 2016, 8:52 PM
This revision was automatically updated to reflect the committed changes.