Differential D24500

Be more explicit about action property types
ClosedPublic
Actions

Authored by ahiemstra on Oct 8 2019, 1:56 PM.

Details

Reviewers
apol
Group Reviewers
Kirigami
Commits
R169:2b7683fe9db9: Be more explicit about action property types
Summary

Now that Kirigami.Action is a Controls.Action, we can be more explicit
about using the Action type where we store it as a property. This adds a
bit of type safety and additionally allows binding of the action's
properties in more cases.

Test Plan

Run kirigami2gallery, see that things that use actions still work correctly.

Diff Detail

Repository
R169 Kirigami
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
ahiemstra created this revision.Oct 8 2019, 1:56 PM
Restricted Application added a project: Kirigami. · View Herald TranscriptOct 8 2019, 1:56 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
ahiemstra requested review of this revision.Oct 8 2019, 1:56 PM
apol accepted this revision.Oct 8 2019, 2:18 PM
This revision is now accepted and ready to land.Oct 8 2019, 2:18 PM
Closed by commit R169:2b7683fe9db9: Be more explicit about action property types (authored by ahiemstra). · Explain WhyOct 9 2019, 11:36 AM
This revision was automatically updated to reflect the committed changes.

Showing Only Differences

This revision modifies 3 more files that are hidden because they were not modified between selected diffs and they have no inline comments.

Revision Contents
Changeset List

Path
No data available.

Diff 67542