Remove redundant manual focusOut handling in DesktopView
ClosedPublic

Authored by davidedmundson on Aug 15 2016, 10:01 AM.

Details

Summary

It makes no sense to modify the focus of containment within it's
FocusScope, and activeFocus will be set correctly by code in
QQuickWindow. Especially as it doesn't set it back.

The only way this would make any sense is if someone in Desktop is
incorrectly using "focus" when they mean to use "activeFocus". This code
was introduced to fix a bug in the toolbox (331971) where someone was
making the mistake above.

That toolbox code has been subsequently fixed properly, leaving this as
dead code.

Test Plan

Toolbox still closes appropriately.
Everything else still seems the same

Diff Detail

Repository
R120 Plasma Workspace
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
davidedmundson retitled this revision from to Remove redundant manual focusOut handling in DesktopView.
davidedmundson updated this object.
davidedmundson edited the test plan for this revision. (Show Details)
davidedmundson added a reviewer: Plasma.
Restricted Application added a project: Plasma. · View Herald TranscriptAug 15 2016, 10:01 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
broulik accepted this revision.Aug 15 2016, 10:19 AM
broulik added a reviewer: broulik.
This revision is now accepted and ready to land.Aug 15 2016, 10:19 AM
This revision was automatically updated to reflect the committed changes.