Fix 'No display of transactions in the tags view when tags are specified in a split'
ClosedPublic

Authored by habacker on Sat, Oct 5, 4:47 PM.

Details

Summary

Since it is currently not clear whether this change will lead
to unwanted side effects at other code locations, the new method
setConsiderCategorySplits() has been added to enable this
functionality.

BUG:412429
FIXED-IN:5.0.8

Test Plan

tested on linux with mymoneytransactionsfiltertest

Diff Detail

Repository
R261 KMyMoney
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
habacker requested review of this revision.Sat, Oct 5, 4:47 PM
habacker created this revision.
habacker updated this revision to Diff 67359.Sat, Oct 5, 9:06 PM
habacker edited the test plan for this revision. (Show Details)
  • minor doc update
  • add note about test with mymoneytransactionfiltertest
tbaumgart requested changes to this revision.Sun, Oct 6, 4:38 PM
tbaumgart added inline comments.
kmymoney/mymoney/tests/mymoneytransactionfilter-test.cpp
539

Looks like this did not get updated after renaming. I get

error: ‘class MyMoneyTransactionFilter’ has no member named ‘setCheckSplitsInCategories’

filter.setCheckSplitsInCategories(true);
       ^~~~~~~~~~~~~~~~~~~~~~~~~~
This revision now requires changes to proceed.Sun, Oct 6, 4:38 PM
habacker updated this revision to Diff 67404.Mon, Oct 7, 7:06 AM
habacker edited the summary of this revision. (Show Details)
  • fixed incorrect function name (sorry for wasting your time)
habacker marked an inline comment as done.Mon, Oct 7, 7:07 AM

Since it is currently not clear whether this change will lead
to unwanted side effects at other code locations,

Some of these locations are checked and handled by fixing other related bugs, such as https://bugs.kde.org/show_bug.cgi?id=404527, which requires an extension of the tests for the QueryTable class.

Are there any other problems preventing the committing of this patch ?

In D24426#543969, @habacker wrote among others:
Are there any other problems preventing the committing of this patch ?

Until yet only time constraints on my end to complete the review. I'll take a look as soon as I can.

Should kmymoney be added as either subscriber or reviewer?

tbaumgart accepted this revision.Thu, Oct 10, 5:19 PM

Fixes the reported problem. Report 'Transactions by tags' still does not show them, so it could be that the flag needs to be set at another spot as well.

This revision is now accepted and ready to land.Thu, Oct 10, 5:19 PM
This revision was automatically updated to reflect the committed changes.
Report 'Transactions by tags' still does not show them, so it could be that the flag needs to be set at another spot as well.

for the record: This issue was reported with bug 406403 (https://bugs.kde.org/show_bug.cgi?id=406403)