Since it is currently not clear whether this change will lead
to unwanted side effects at other code locations, the new method
setConsiderCategorySplits() has been added to enable this
functionality.
BUG:412429
FIXED-IN:5.0.8
Details
Details
- Reviewers
tbaumgart - Group Reviewers
KMyMoney - Commits
- R261:65461d923923: Fix 'No display of transactions in the tags view when tags are specified in a…
tested on linux with mymoneytransactionsfiltertest
Diff Detail
Diff Detail
- Repository
- R261 KMyMoney
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
| kmymoney/mymoney/tests/mymoneytransactionfilter-test.cpp | ||
|---|---|---|
| 539 | Looks like this did not get updated after renaming. I get error: ‘class MyMoneyTransactionFilter’ has no member named ‘setCheckSplitsInCategories’ filter.setCheckSplitsInCategories(true);
^~~~~~~~~~~~~~~~~~~~~~~~~~ | |
Comment Actions
Since it is currently not clear whether this change will lead
to unwanted side effects at other code locations,
Some of these locations are checked and handled by fixing other related bugs, such as https://bugs.kde.org/show_bug.cgi?id=404527, which requires an extension of the tests for the QueryTable class.
Are there any other problems preventing the committing of this patch ?
Comment Actions
In D24426#543969, @habacker wrote among others:
Are there any other problems preventing the committing of this patch ?
Until yet only time constraints on my end to complete the review. I'll take a look as soon as I can.
Comment Actions
Fixes the reported problem. Report 'Transactions by tags' still does not show them, so it could be that the flag needs to be set at another spot as well.
Comment Actions
for the record: This issue was reported with bug 406403 (https://bugs.kde.org/show_bug.cgi?id=406403)